search

apache / openwhisk-composer

Apache OpenWhisk Composer provides a high-level programming model in JavaScript for composing serverless functions
https://openwhisk.apache.org/
Apache License 2.0
68 stars 21 forks source link

Fixed bug when using boolean value annotations with deploy #70

Closed dylandepass closed 3 years ago

dylandepass commented 4 years ago

Currently if you try and use a boolean valued annotation with the deploy command the value is treated as a string and not a boolean.

For example

deploy aio-tests-0.0.1/test-composer actions/test-composer/index.json -w --annotation web-export=true

Results in the web-export being set to 'true' and not the boolean value true. The web-export annotation does not work if the value is set to 'true'

Screen Shot 2020-03-17 at 11 14 43 AM

This PR attempts to fix that.

dgrove-oss commented 3 years ago

@tardieu -- any objection to merging this PR?

rabbah commented 3 years ago

Docs state it must be true https://github.com/apache/openwhisk/blob/master/docs/annotations.md#annotations-specific-to-web-actions, and code reads the value as a Boolean https://github.com/apache/openwhisk/blob/9134a03c37f9be104cfc3523748ea6b8cfbfea38/core/controller/src/main/scala/org/apache/openwhisk/core/controller/WebActions.scala#L741.

dgrove-oss commented 3 years ago

going to close & reopen to get a run on travis-ci.com