Fixes SSL support for AWS ELBs and signed certificates

apache / openwhisk-deploy-kube

The Apache OpenWhisk Kubernetes Deployment repository supports deploying the Apache OpenWhisk system on Kubernetes and OpenShift clusters.

https://openwhisk.apache.org/

Apache License 2.0

302 stars 232 forks source link

Fixes SSL support for AWS ELBs and signed certificates #593

Closed buggtb closed 4 years ago

dgrove-oss commented 4 years ago

At first read through, this looks reasonable. Thanks!

I will give it a whirl on IBM IKS service within the next 24 hours as a sanity check.

Could you fix the scancode violations:

  [/home/travis/build/apache/openwhisk-deploy-kube/tools/travis/../../docs/k8s-aws.md]:
      94: line has trailing whitespace.
     108: line has trailing whitespace.
     109: line has trailing whitespace.

dgrove-oss commented 4 years ago

@buggtb -- I tested your branch on an IKS cluster (IBM Kubernetes Service) and locally and everything worked fine. As expected non-AWS targets are not impacted. If you could fix up the three lines in docs/k8s-aws.md that have trailing white space, I will merge the PR (I seem to not have permission to just fix them myself on your branch).

dgrove-oss commented 4 years ago

Replaced by #597