Fix issue with quoted docker registry credentials

apache / openwhisk-deploy-kube

The Apache OpenWhisk Kubernetes Deployment repository supports deploying the Apache OpenWhisk system on Kubernetes and OpenShift clusters.

https://openwhisk.apache.org/

Apache License 2.0

302 stars 232 forks source link

Fix issue with quoted docker registry credentials #613

Closed mluds closed 4 years ago

mluds commented 4 years ago

The docker registry credentials are quoted here: https://github.com/apache/openwhisk-deploy-kube/blob/bbf7846517ed690bb0bf2fdda444222a82037aa8/helm/openwhisk/templates/ow-docker-registry-secret.yaml#L26-L27

When used in the dockerPullRuntimes Ansible, literal quotes are passed in the username and password, breaking authentication.

This fixes that by stripping these before use.

dgrove-oss commented 4 years ago

I think quoting the values before running them through b64enc is a mistake. We don't do that anywhere else. I'll submit a PR to take out the | quote as an alterantive

dgrove-oss commented 4 years ago

I think #616 is a better fix..let's keep the bogus quotes out of the secret

dgrove-oss commented 4 years ago

@mluds - I think #616 should fix this. I merged it this morning. When you get a chance, could you give it a try and let us know if I missed something? Thanks

mluds commented 4 years ago

Sorry for the late response, but I just tried this and looks like it's working. Thanks!