apache / openwhisk-deploy-kube

The Apache OpenWhisk Kubernetes Deployment repository supports deploying the Apache OpenWhisk system on Kubernetes and OpenShift clusters.
https://openwhisk.apache.org/
Apache License 2.0
301 stars 231 forks source link

Deploy with new scheduler #729

Closed hunhoffe closed 2 years ago

hunhoffe commented 2 years ago

What this PR contains:

Some changes are needed to the scheduler to support the akka cluster discovery mechanism. The scheduler also needs to be integrated into the build process. These changes are in PR#5278 of apache/openwhisk.

Tasks:

Future Work:

hunhoffe commented 2 years ago

Having issues with inProgressJobRetention parsing in new scheduler image, see: https://github.com/apache/openwhisk/pull/5281

style95 commented 2 years ago

@hunhoffe This is great! Thank you for your contribution.

hunhoffe commented 2 years ago

I believe I've addressed all comments except the external etcd feature. I wrote a comment that it is not yet supported in the values.yaml file, and I'm hoping that it is a feature that could be added later; I could create an issue for it so it is not forgotten if that's acceptable.

style95 commented 2 years ago

I could create an issue for it so it is not forgotten if that's acceptable.

I am ok with this.

hunhoffe commented 2 years ago

I created an issue for the external etcd support and fixed the timestamp (https://github.com/apache/openwhisk-deploy-kube/issues/751). Pending any further feedback, I believe this is ready for merge. Thank you for your time in reviewing @style95 and @dgrove-oss!