search

apache / openwhisk-devtools

Development tools for building and deploying Apache OpenWhisk
https://openwhisk.apache.org/
Apache License 2.0
180 stars 126 forks source link

make tmp directory as a modifiable parameter #264

Closed axiqia closed 5 years ago

axiqia commented 5 years ago

The tmp directory in Makefile was hard-coded as ~ before, may the user need to change the tmp directory to somewhere else for some reason, for me, ~ is not writable for my root account, so I make the tmp directory as a modifiable parameter now.

Relate issue: https://github.com/apache/incubator-openwhisk-devtools/issues/179

rabbah commented 5 years ago

Thanks for the fix. Why is the change set so big?

axiqia commented 5 years ago

Well, actually I only add one line and replace the tmp directory. Probably because I downloaded the file to my local PC to edit and then overwrite the file.

axiqia commented 5 years ago

@rabbah I cloned a new repertoty and use git diff --ignore-space-at-eol to see the difference. There is a ^M at the end of each line. So, it is because the file was edited in Windows it used CR line endings, and in Ubuntu it uses LF line endings.

I'm sorry to trouble you, May I need to open a new PR?