search

apache / openwhisk-devtools

Development tools for building and deploying Apache OpenWhisk
https://openwhisk.apache.org/
Apache License 2.0
180 stars 126 forks source link

Docker images missing "latest" tag #269

Closed phlucas96 closed 5 years ago

phlucas96 commented 5 years ago

Some of the docker images are missing the "latest" tag, "openwhisk/invoker" and "openwhisk/controller". As a result, the Makefile used during the Docker compose installation is having errors, such as: "Error response from daemon: manifest for openwhisk/invoker:latest not found".

dgrove-oss commented 5 years ago

@rabbah @ddragosd -- I don't use docker-compose myself, so I'm not sure what the best semantics are here. If this is a developer oriented deployment mechanisms, then I suspect it should be doing openwhisk/FOO_IMAGE:nightly or whisk/FOO_IMAGE:latest depending on whether it is deploying locally built images or pre-built images from dockerhub? WDYT?

tawalaya commented 5 years ago

Got the same issue. It looks like the latest tags where deleted on docker-hub which is the cause of the issue. Changing all tags in the compose files and the make file to nightly might work.

rabbah commented 5 years ago

This PR https://github.com/apache/incubator-openwhisk-devtools/pull/270 should address the issue.

I used nightly although it's possible to override for latest.

dgrove-oss commented 5 years ago

merged #270

rabbah commented 5 years ago

going to speculatively close as fixed y above mentioned PR.