search

apache / openwhisk-package-alarms

Apache OpenWhisk package that can be used to create periodic, time-based alarms.
https://openwhisk.apache.org/
Apache License 2.0
24 stars 49 forks source link

Add worker&host to logging #146

Closed KeonHee closed 6 years ago

KeonHee commented 6 years ago

We transmit logs to external platform and from there we check logs, but there is no host&worker information in the logs.

If the log contains host information, it is possible to detect duplicate active hosts with logs.

So I changed the log format.

jasonpet commented 6 years ago

this breaks the kibana query for the component field. with this change it is now set to None instead of alarmsTrigger.

jasonpet commented 6 years ago

Please see the expected format comment: https://github.com/apache/incubator-openwhisk-package-alarms/blob/7923ba53764524967a8000b9fb7cf7e527b23490/provider/Logger.js#L41

jasonpet commented 6 years ago

I would recommend you put this information in the message if you need it. I personally name my container name in a way that gives me the worker and host.

KeonHee commented 6 years ago

@jasonpet Thank you for your review.

I think it is good to include workers and hosts in the logs explicitly because they are very important concepts. What do you think?

jasonpet commented 6 years ago

yeah, I definitely agree that they are important for anyone using the HA support for alarms