search

apache / openwhisk-package-alarms

Apache OpenWhisk package that can be used to create periodic, time-based alarms.
https://openwhisk.apache.org/
Apache License 2.0
24 stars 49 forks source link

Encode database authentication information for issue with special characters #155

Closed KeonHee closed 4 years ago

KeonHee commented 6 years ago

Relate to:

The last PR did not work in couchdb either(Sorry...!). So I found a new method, and I am using it in my in-house paas. I hope that cloudant will also work.

I adjusted the database settings of the provider and package to the same, and modified the deployment script.

KeonHee commented 6 years ago

@jasonpet I modified it to use an existing url and add only username and password.

dgrove-oss commented 4 years ago

@jasonpet - should this be closed as stale?

style95 commented 4 years ago

Can we include this change?

KeonHee commented 4 years ago

Like https://github.com/apache/openwhisk-package-alarms/pull/155#pullrequestreview-141367905, I have modified to use the existing DB_URL. And this change still works well.

rabbah commented 4 years ago

LGTM - I've been working with the alarm package recently and can try this out.

style95 commented 4 years ago

It seems I cannot merge this PR because @jasonpet requested changes. @jasonpet Do you still have any comments on this?

rabbah commented 4 years ago

I think the changes made address the requested change and we can unblock the PR but I'll ping Jason on Slack as a courtesy.

rabbah commented 4 years ago

Thanks @jasonpet.