search

apache / openwhisk-package-alarms

Apache OpenWhisk package that can be used to create periodic, time-based alarms.
https://openwhisk.apache.org/
Apache License 2.0
24 stars 49 forks source link

Make cron triggers fire with random delay with parameter `strict` #198

Closed machenity closed 4 years ago

machenity commented 4 years ago

I made an implementation of what I suggested in #196 A parameter strict is added in alarms/alarm feed to enable the firing distribution. If user passes the boolean value true (or nothing; it's default), firing will act like usual. Distribution is only enabled when strict=false is passed.

style95 commented 4 years ago

@machenity Thank you for the contribution. It would be great to share the impact of this change.

Could you share results before/after this change?

style95 commented 4 years ago

@machenity Could you share this change to the dev mailing list as well?

machenity commented 4 years ago

@style95 Thanks for your rewordings. But adding a configuration maximum option can be a little tricky. I think adding two parameters(e.g. {strict: boolean, max_delay: number}) is too abundant for just one option.

style95 commented 4 years ago

@machenity Actually, strict would be exposed to users but max_delay would only be exposed to operators. So max_delay is a deployment option, and I think it is a viable option.