apache / openwhisk-package-kafka

Apache OpenWhisk package for communicating with Kafka or Message Hub
https://openwhisk.apache.org/
Apache License 2.0
32 stars 43 forks source link

Add rule and action to trigger tests which rely upon activation records #230

Closed abaruni closed 6 years ago

abaruni commented 6 years ago

In order to support the removal of activation records for any trigger fires not attached to a rule, the tests which rely upon the presence of trigger activation records have been updated to create a simple hello action and a rule

abaruni commented 6 years ago

@jasonpet will you give this a look?

abaruni commented 6 years ago

@csantanapr fyi

csantanapr commented 6 years ago

@jasonpet could you review and let me know

jasonpet commented 6 years ago

LGTM

markusthoemmes commented 6 years ago

What's the intended change in behavior here? Side-effects of hello.js are not observable so tests till evaluate activation list, no?

Edit: Nevermind, thought this was intended for another fix.