apache / openwhisk-package-kafka

Apache OpenWhisk package for communicating with Kafka or Message Hub
https://openwhisk.apache.org/
Apache License 2.0
33 stars 43 forks source link

Allow feed to be deleted if trigger does not exist #359

Closed dubee closed 4 years ago

dubee commented 4 years ago

If for some reason a trigger has been deleted though the associated feed still exists, a user cannot delete the corresponding feed manually.

rabbah commented 4 years ago

@dubee does this affect other openwhisk feed providers? Can you mention this on the dev list 🙏

dubee commented 4 years ago

@rabbah, sure. This and https://github.com/apache/openwhisk-package-kafka/pull/360 affect the other providers.

jasonpet commented 4 years ago

this functionality has always existed for the other providers (Cloudant and Alarms)

dubee commented 4 years ago

@rabbah, correction on that last comment. Alarms and Cloudant providers already allow for deletion of a feed that is triggerless. Changes here are to have the equivalent functionality for the Kafka provider. https://github.com/apache/openwhisk-package-kafka/pull/360 on the other hand does apply to the other providers.