search

apache / openwhisk-package-kafka

Apache OpenWhisk package for communicating with Kafka or Message Hub
https://openwhisk.apache.org/
Apache License 2.0
33 stars 43 forks source link

Update actions from nodejs:6 to nodejs:10 #367

Closed dgrove-oss closed 4 years ago

dgrove-oss commented 4 years ago

The installCatalog.sh and installKafka.sh scripts select nodejs:6 as the runtime kind. NodeJS 6 is long past EOL; we need to update to select nodejs:10 instead.

The actual change is trivial, but travisci is not setup to actually do comprehensive testing of this repository, so verifying that the actions all still work with the sparser dependencies of the nodejs:10 kind is where the work is. Ideally, really travis testing would be configured as a side-effect of doing this work.

Shariar076 commented 4 years ago

It doesn't work!! Removing the parameter --kind just results in error: Invalid argument(s). creating an action from a .zip artifact requires specifying the action kind explicitly.

Please update the code to newer runtime version. It is very unfortunate that one of the vital packages is not being updated with the main s/w.

rabbah commented 4 years ago

You can't remove the kind - the change looks like this https://github.com/apache/openwhisk-package-kafka/pull/369. But there aren't tests as Dave indicated for us to know the actions work in newer runtimes with no dependencies.

rabbah commented 4 years ago

Closed by #369.

rabbah commented 4 years ago

We still need to improve travisci but that's a different issue.

Shariar076 commented 4 years ago

You can't remove the kind - the change looks like this #369. But there aren't tests as Dave indicated for us to know the actions work in newer runtimes with no dependencies.

got it thanks