search

apache / openwhisk-runtime-dotnet

Apache OpenWhisk Runtime .Net supports Apache OpenWhisk functions written in .Net languages
https://openwhisk.apache.org/
Apache License 2.0
34 stars 28 forks source link

.NET 6.0 Support #68

Closed shawnallen85 closed 1 year ago

shawnallen85 commented 1 year ago

Removed .NET Core 2.2 since it is no longer supported by Microsoft.

Added .NET 6.0.

Added Vagrant for development purposes.

ElanHasson commented 1 year ago

Hi @shawnallen85, This is awesome, thanks for putting this together!

Did you opt for .NET 6 over 7 because it is the LTS release?

shawnallen85 commented 1 year ago

Elan,

That is correct.

Thanks,

Shawn

On 11/22/22 17:14, Elan Hasson wrote:

Hi @shawnallen85 https://github.com/shawnallen85, This is awesome, thanks for putting this together!

Did you opt for .NET 6 over 7 because it is the LTS release?

— Reply to this email directly, view it on GitHub https://github.com/apache/openwhisk-runtime-dotnet/pull/68#issuecomment-1324002073, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCRPEJM6WC6LX2SVJ275R3WJT5P7ANCNFSM6AAAAAASGE2NOQ. You are receiving this because you were mentioned.Message ID: @.***>

mattwelke commented 1 year ago

@shawnallen85 I notice that in https://github.com/apache/openwhisk-runtime-dotnet/pull/61, the PR creator switches it from Newtonsoft to System.Json.Text and you commented saying that you agreed with that change. Any plans to do the same for this PR?

shawnallen85 commented 1 year ago

@mattwelke #61 isn't from me. I don't think changing the default JSON serializer makes sense yet as System.Text.Json doesn't have feature parity when compared to Newtonsoft.Json.

Going back a few months, there was a discussion about abstracting the serialization to where the function owner could pick the serializer, but I haven't seem much feedback from that idea (other than I think your feedback if I recall).