search

apache / openwhisk-runtime-nodejs

Apache OpenWhisk Runtime NodeJS supports Apache OpenWhisk functions written in JavaScript for NodeJS
https://openwhisk.apache.org/
Apache License 2.0
60 stars 72 forks source link

Expand support for entry point handler to allow module.nested.main. #132

Closed rabbah closed 5 years ago

rabbah commented 5 years ago

Closes #131.

I extended our tests to cover this change. Some of the format changes in the test suite are just white space, you can ignore those by reviewing the changes here https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/132/files?w=1.

rabbah commented 5 years ago

@jthomas nudge.

jthomas commented 5 years ago

Code LGTM.

Can you update the Node.js docs in the main repo to highlight this new feature?

Minor nitpick for future reference - default to using const rather than let in code where values aren't expected to change as it'll catch errors for us early.

rabbah commented 5 years ago

Thanks for the review and feedback.

For usage documentation I was planning to update the docs in OpenWhisk repo since the readme here mainly emphasizes development of the image. Not usage.

For js-isims I have a second PR In the wings.