Closed meenakshimadugula95 closed 2 years ago
@meenakshimadugula95 Apart from specific review comments... Could we also, in this PR, update the top-level README to better inform people what they will find when referencing the "Docker" build path and also perhaps simplify (correct) the "two ways to build" section which is confusing IMO.
@mrutkows thank you for the comments. I have modified the tutorial file so that it is better structured and easily readable. Please review this while I edit the top level readme.
I have corrected the top level readme to reflect the two option to build python runtimes. Please take a look and review
I was following the instructions to build the docker file locally by following the tutorial on here. However the command for
docker build
was failing. I noticed failures in building the docker files for all available runtimes. The reason being the expected dependent files/folders were not available in the docker context. The Gradle builds would essentially pass as they are copying the dependencies before building the docker. For example https://github.com/apache/openwhisk-runtime-python/blob/master/core/python3Action/build.gradle#L25To solve this problem, I had brainstormed multiple solutions, I came up with this one as it does not affect any dependencies on the dockerfile. The gradle builds should be able to pass as they were earlier.
Solution:
./tutorials/local_build.sh -r python3Action -t action-python-v3.7:1.0-SNAPSHOT
The script tries to mimic the Gradle files by copying the dependent folder/files, building the docker file and then deleting the dependent folders/files. I have updated the tutorial document with the same instructions. This PR would help anyone trying to build the runtime images locally.