search

apache / openwhisk-wskdeploy

Apache OpenWhisk utility for deploying and managing OpenWhisk projects and packages
https://openwhisk.apache.org/
Apache License 2.0
77 stars 74 forks source link

memorySize is limited client-side #1033

Open TPei opened 5 years ago

TPei commented 5 years ago

wskdeploy limits memory size to 512mb. To me, it is unclear why that is. I'd propose raising those limits, OpenWhisk (at least on IBM) supports up to 2048MB limits

TPei commented 5 years ago

Hmm, ok, according to the documentation, the memory limit is still 512MB https://github.com/apache/incubator-openwhisk/blob/master/docs/reference.md

TPei commented 5 years ago

hmm, @rabbah shed some light on the issue: "openwhisk operators can configure these limits at deployment time". Makes me wonder if more than 512MB should be allowed here. Right now the setting is just ignored. The warning is only shown when deploying with -v (verbose) and then there's so much output that it's very hard to notice...

Could we instead show a warning and still use the setting? What would this mean if the setting is actually invalid for the provider?

rabbah commented 5 years ago

I haven’t looked at the implementation here but any hard coding of limits in the wskdeploy client is a bug in my opinion and should be read from the api host which provides them.

There is an issue I opened related to the runtime kinds for example which bit me sometime ago.

rabbah commented 5 years ago

Why is this closed?

TPei commented 5 years ago

Just because the PR was merged, bu the underlying issue (hard coding client-side vs reading from api host) still remains, I guess. Updated the title accordingly

TPei commented 5 years ago

the API (such as https://openwhisk.ng.bluemix.net/) returns the memory size limit as "limits.max_action_memory", this can be used accordingly I'd say