Open advancedwebdeveloper opened 3 years ago
This on behalf of https://groups.google.com/g/golang-nuts/c/S2gBW3BV4QU/m/I4gWtrPxBwAJ Also consider investigating https://github.com/json-iterator/go/issues/501
@advancedwebdeveloper Thank you for the contribution.
How about opening a PR with your change and describe your intention more here?
@advancedwebdeveloper Running the "goTest" (gradle command) has never been valid in local configurations (especially for integration tests which requires a full OpenWhisk backend plus all providers installed and working with backing services). As the README states, you should run only "unit" tests locally with "go test" (actual go command); "go test" integration tests will only work in Travis as the needed credentials are provided in that environment.
FWIW, The direction of the client tools (wskdeploy and CLI) is one where gogradle (which has not been updated since 2017 and is hardcoded to the deprecated govendor) is replaced with a newer plugin or removed altogether.
@advancedwebdeveloper Running the "goTest" (gradle command) has never been valid in local configurations (especially for integration tests which requires a full OpenWhisk backend plus all providers installed and working with backing services). As the README states, you should run only "unit" tests locally with "go test" (actual go command);
OK, understood.
"go test" integration tests will only work in Travis as the needed credentials are provided in that environment.
And how would I run Travis in my local environment? Or you want me to fork on Github - and your bot would push a job to Travis, automatically?
FWIW, The direction of the client tools (wskdeploy and CLI) is one where gogradle (which has not been updated since 2017 and is hardcoded to the deprecated govendor) is replaced with a newer plugin or removed altogether.
OK, I am just following the current instructions.
And how would I run Travis in my local environment? Or you want me to fork on Github - and your bot would push a job to Travis, automatically?
Travis is not run locally, but in the Travis CI servers that are paid for by the Apache Software Foundation. If you submit a pull request, a Travis PR job will be run, and our Travis scripts will automate the install of OpenWhisk and its services and run all unit and integration tests. Of course, you can change the build.gradle to attempt to build for a new architecture (if it is supported on the compiler) by adding the architecure's acronym to the build matrix. However, If it is your intent to run the resultant binary (executable) on a new architecture that would likely be a manual process (at the moment) by taking the matching binary and actually running it on a machine of that architecture (unit tests only unless you want to figure out how to install a full production OW platform locally). There may be possibilities that 3rd party services might support Travis jobs/testing that could be enabled within Travis to test on specific platforms (e.g., we have tried for Windows, but it was very involved to enable this with Apache infra. team). TBH, I have no knowledge if these 3rd party exist (especially for a new architecture) and am doubtful they may for your specific case.
One question though... it was my belief that AARCH64 and ARM64 were the same (merged) and not sure why supporting this architecture (by name/acronym) is important? i.e., https://www.phoronix.com/scan.php?page=news_item&px=MTY5ODk
and a recent blog post confirms our linux-arm64 would work on aarch64 servers… https://opensource.com/article/21/1/go-cross-compiling
and reading this (although they neglect to say they removed support for Darwin 32-bit in Go 1.15) indicates 1.16 beta will support new M1 chips (better?) https://blog.golang.org/ports (is this why I see a PR for 1.16.2? https://github.com/apache/openwhisk-wskdeploy/pull/1132)
So, while I was able to build
with such an applied patch: https://gist.github.com/advancedwebdeveloper/9ee1d333d0101b06823735cf871055b1 .
Now, test are failing:
test_report.zip