search

apache / openwhisk-wskdeploy

Apache OpenWhisk utility for deploying and managing OpenWhisk projects and packages
https://openwhisk.apache.org/
Apache License 2.0
77 stars 74 forks source link

Rules and triggers are not created under the package defined in manifest #514

Open daisy-ycguo opened 7 years ago

daisy-ycguo commented 7 years ago

I noticed that rules and triggers are not created under package defined in manifest. For example, after deploying the cloudant use case (manifest.yaml), following items will be created. Actions are in package cloudant-sample, but rules and triggers are in default package. I think it is a bug and it should be fixed.

Entities in namespace: guoyingc@cn.ibm.com_dev
packages
/guoyingc@cn.ibm.com_dev/openwhisk-cloudant                            private
/guoyingc@cn.ibm.com_dev/cloudant-sample                               private
actions
/guoyingc@cn.ibm.com_dev/cloudant-sample/process-change-cloudant-sequence private sequence
/guoyingc@cn.ibm.com_dev/cloudant-sample/process-change                private nodejs:6
triggers
/guoyingc@cn.ibm.com_dev/data-inserted-trigger                         private
rules
/guoyingc@cn.ibm.com_dev/log-change-rule                               private
daisy-ycguo commented 7 years ago

I noticed there is a boolean DeployActionInPackage defined in ServiceDeployer(source code is here). If this boolean is true, actions will be deployed under package. The boolean is set to true as default, and there is no way to change it to false.

I wonder if we shall do the same to triggers and rules.

daisy-ycguo commented 7 years ago

It is by design as to now. We will keep this issue to track the discussions.