search

apache / openwhisk

Apache OpenWhisk is an open source serverless cloud platform
https://openwhisk.apache.org/
Apache License 2.0
6.54k stars 1.17k forks source link

Use Maven based dependency instead of gradle project based dependency #3277

Closed chetanmeh closed 6 years ago

chetanmeh commented 6 years ago

Currently other OpenWhisk repositories refer to OpenWhisk modules like common, core and test via Gradle project dependency. This creates a tight coupling between the repositories and poses problem as seen in #3249

With #3061 support was added to generate Maven artifacts and install them in local repositories. Other repositories should leverage these artifacts as dependency. This would later allow them to be pulled from Maven repositories.

the plan of action is to find out all other projects which rely on openwhisk core project via project dependency and then modify them in following way

Switch to Maven based dependency

repositories {
    mavenCentral()
    mavenLocal()
}
dependencies {
    compile "org.apache.openwhisk:openwhisk-common:${gradle.openwhisk.version}"    
}

Modify travis build to perform Maven install

./gradlew install distDocker

Based on this search there are 8 such modules which need to be modified.

chetanmeh commented 6 years ago

Below is the list of all OpenWhisk projects which need to be checked for dependency on core. We cannot just rely on sourcegraph as it does not list all modules. For e.g. incubator-openwhisk-runtime-swift has a dependency but is not listed in search result. So need to be manually check

Below is the list of various OpenWhisk projects. Those marked as checked are those which have been converted or not need to be converted

:white_check_mark: - Need changes :white_check_mark: - Need changed and changed

chetanmeh commented 6 years ago

Opened PR on all 13 repo which need changes. Once those are merged we can make changes in core

jasonpet commented 6 years ago

incubator-openwhisk-package-alarms and incubator-openwhisk-package-cloudant can be marked as done in the table above

csantanapr commented 6 years ago

@chetanmeh I merged all the PRs Thanks 💯 👍

chetanmeh commented 6 years ago

Thanks @csantanapr and @jasonpet . Resolving this as done then