Swift action parsing doesn't tolerate special characters

[jberstler]

For example, if I try to run an action with the following code:

//  Copyright © 2016 Dirk Beanberger. All rights reserved.
func main(args: [String:Any]) -> [String:Any] {
  return ["message": "This should just work..."]
}

I always get an error of the action did not produce a valid JSON response

However, if I simply remove the © everything works as expected.

[rabbah]

This may not be specific to Swift - see #252 (if you do resolve the Swift-specific issue, you will run into 252 next).

[jberstler]

@rabbah That seems pretty likely. The Swift action file handling already is explicit about using UTF-8. I suggest keeping this open to verify that #252 actually fixes this specific symptom.

[rabbah]

Your symptom is different - the action did not produce a valid JSON response suggests there was a failure executing the action (I would check the proxy for example to confirm it returned the correct value). The defect from 252 will manifest differently (the activation record will show a different result value).

[rabbah]

@bjustin-ibm @paulcastro is this still valid?

[jberstler]

@rabbah It is still valid. On the Swift 3 runtime, I get the following error, but only with the copyright character present:

{
  "error": "The action failed to generate or locate a binary. See logs for details."
}

[paulcastro]

@bjustin-ibm that message indicates a compilation error.

[stevenatkin]

I believe that this is tied to #252. We really need to get someone to take a look at this. I don't think that this should be too hard to fix. I think the problem is that they are running OpenWhisk in the wrong codepage they should be running in UTF-8. My guess is that they are probably defaulting to ISO8859-1 (Latin 1) when they should be using Unicode.

[rabbah]

The fix for #252 is necessary but not sufficient to fix swift (and python) actions. The proxy needs to handle utf-8 encoding, where it currently does not; pr #1757 includes the required invoker side fix.

[rabbah]

proposed patch https://github.com/openwhisk/openwhisk/commit/4f2c1043abf754591ab3d7a35947b41ff2000d4c.

[rabbah]

Fix merged via #1757. Leaving open however to investigate Travis failure via CLI tests of new unicode python/swift actions.

[cclauss]

Is this still in progress?

[rabbah]

The Travis issue might still exist. I have not investigated.

[rabbah]

Looks like we have a recent regression in the swift actions.

[rabbah]

tests enabled in pr #2070.