apache / openwhisk

Apache OpenWhisk is an open source serverless cloud platform
https://openwhisk.apache.org/
Apache License 2.0
6.56k stars 1.17k forks source link

remove zookeeper config requirement #5375

Closed bdoyle0182 closed 1 year ago

bdoyle0182 commented 1 year ago

Description

First step to getting rid of the zookeeper dependency on the invokers. Invokers currently can already be started without the zookeeper config if --id flag is set which is already the case in ansible. The only case that needs to be covered still before removing the dependency is adding support for kubernetes deployment. If started without config and need to connect to zookeeper still, the invoker will fail and shut down anyways from failing to connect to zookeeper in the instance id assigner on startup so this shouldn't be a breaking change.

Related issue and scope

My changes affect the following components

Types of changes

Checklist:

codecov-commenter commented 1 year ago

Codecov Report

Merging #5375 (703c3a8) into master (096dba4) will decrease coverage by 61.94%. The diff coverage is n/a.

:exclamation: Current head 703c3a8 differs from pull request most recent head 3a3407b. Consider uploading reports for the commit 3a3407b to get more accurate results

@@            Coverage Diff             @@
##           master   #5375       +/-   ##
==========================================
- Coverage   66.46%   4.53%   -61.94%     
==========================================
  Files         240     240               
  Lines       14569   14567        -2     
  Branches      642     647        +5     
==========================================
- Hits         9684     660     -9024     
- Misses       4885   13907     +9022     
Impacted Files Coverage Δ
...la/org/apache/openwhisk/core/invoker/Invoker.scala 0.00% <ø> (-72.50%) :arrow_down:
...rg/apache/openwhisk/core/scheduler/Scheduler.scala 0.00% <ø> (-1.90%) :arrow_down:
...ain/scala/org/apache/openwhisk/spi/SpiLoader.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...n/scala/org/apache/openwhisk/utils/JsHelpers.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...scala/org/apache/openwhisk/common/Prometheus.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...scala/org/apache/openwhisk/core/FeatureFlags.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...scala/org/apache/openwhisk/http/CorsSettings.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...ala/org/apache/openwhisk/common/ConfigMXBean.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...la/org/apache/openwhisk/http/BasicRasService.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...a/org/apache/openwhisk/common/ConfigMapValue.scala 0.00% <0.00%> (-100.00%) :arrow_down:
... and 184 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more