bdoyle0182 commented 1 year ago

Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Scheduler
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[X] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

codecov-commenter commented 1 year ago

Codecov Report

Merging #5384 (ce08108) into master (65a0132) will increase coverage by 0.21%. The diff coverage is n/a.

:exclamation: Current head ce08108 differs from pull request most recent head a15866f. Consider uploading reports for the commit a15866f to get more accurate results

@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
+ Coverage   76.45%   76.66%   +0.21%     
==========================================
  Files         240      240              
  Lines       14569    14569              
  Branches      647      647              
==========================================
+ Hits        11139    11170      +31     
+ Misses       3430     3399      -31

Impacted Files	Coverage Δ
.../openwhisk/core/containerpool/ContainerProxy.scala	`95.43% <0.00%> (+0.22%)`	:arrow_up:
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala	`82.10% <0.00%> (+0.56%)`	:arrow_up:
...g/apache/openwhisk/common/ResizableSemaphore.scala	`100.00% <0.00%> (+3.84%)`	:arrow_up:
...la/org/apache/openwhisk/core/etcd/EtcdClient.scala	`60.00% <0.00%> (+4.61%)`	:arrow_up:
...pache/openwhisk/core/invoker/InvokerReactive.scala	`71.53% <0.00%> (+17.69%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

dgrove-oss commented 1 year ago

I'll rerun one of the downstream runtime jobs manually and see what happens...

dgrove-oss commented 1 year ago

I think it made progress, but we're not out of the woods yet. Here's the snippet from the re-run of runttime-go (https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068)

> Task :tests:test FAILED
[30](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:31)
FAILURE: Build failed with an exception.
[31](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:32)

[32](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:33)
* What went wrong:
[33](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:34)
Execution failed for task ':tests:test'.
[34](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:35)
> Could not resolve all files for configuration ':tests:testRuntimeClasspath'.
[35](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:36)
   > Could not find com.atlassian.oai:swagger-request-validator-core:.
[36](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:37)
     Required by:
[37](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:38)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
[38](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:39)
   > Could not find io.github.embeddedkafka:embedded-kafka_2.12:.
[39](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:40)
     Required by:
[40](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:41)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT

bdoyle0182 commented 1 year ago

I think it made progress, but we're not out of the woods yet. Here's the snippet from the re-run of runttime-go (https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068)

> Task :tests:test FAILED
[30](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:31)
FAILURE: Build failed with an exception.
[31](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:32)

[32](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:33)
* What went wrong:
[33](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:34)
Execution failed for task ':tests:test'.
[34](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:35)
> Could not resolve all files for configuration ':tests:testRuntimeClasspath'.
[35](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:36)
   > Could not find com.atlassian.oai:swagger-request-validator-core:.
[36](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:37)
     Required by:
[37](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:38)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT
[38](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:39)
   > Could not find io.github.embeddedkafka:embedded-kafka_2.12:.
[39](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:40)
     Required by:
[40](https://github.com/apache/openwhisk-runtime-go/actions/runs/4258627618/jobs/7419972068#step:9:41)
         project :tests > org.apache.openwhisk:openwhisk-tests:1.0.1-SNAPSHOT

will get the rest of the dependencies from that pr updated and then seems like hopefully it should be good

edit: https://github.com/apache/openwhisk/pull/5385

apache / openwhisk

attempt to fix downstream runtime builds #5384