use compatibility serializer for future message forma…

bdoyle0182 commented 1 year ago

Description

To support future changes to the akka serialized messages that use kryo, we need to use kryo compatibility serializer i.e. to support the max instances pr.

This is a breaking change if trying to rolling upgrade an existing cluster creating new action queues between the scheduler and controller.

If you are not using the new scheduler architecture, this change is completely non-impacting. If you are using the new scheduler architecture, you can either do a blue / green deployment with a new cluster to upgrade or if you must do a rolling upgrade of an existing cluster; you can upgrade the controllers first such that only things that will return 503 during the deployment window are new actions that have not been running, live running queues in the scheduler would continue to be able to take activations.

Since this is a one time breaking serialization change to the scheduler, I've also taken the opportunity to perform the major version akka-kryo upgrade to handle cve's for kryo 4. edit: I've removed this part of the pr as there seems to be other issues with upgrading akka-kryo

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[X] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[X] Scheduler
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[X] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

codecov-commenter commented 1 year ago

Codecov Report

Merging #5389 (ab0bde2) into master (60ca660) will decrease coverage by 0.22%. The diff coverage is 0.00%.

:exclamation: Current head ab0bde2 differs from pull request most recent head 48abf07. Consider uploading reports for the commit 48abf07 to get more accurate results

@@            Coverage Diff             @@
##           master    #5389      +/-   ##
==========================================
- Coverage   76.91%   76.70%   -0.22%     
==========================================
  Files         240      240              
  Lines       14588    14589       +1     
  Branches      629      630       +1     
==========================================
- Hits        11221    11191      -30     
- Misses       3367     3398      +31

Impacted Files	Coverage Δ
...rg/apache/openwhisk/core/scheduler/Scheduler.scala	`10.75% <0.00%> (-0.07%)`	:arrow_down:

... and 11 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

style95 commented 1 year ago

Do we need to send a notice about the breaking change via the dev mailing list?

apache / openwhisk