update scheduler not processing metric to counter

apache / openwhisk

Apache OpenWhisk is an open source serverless cloud platform

https://openwhisk.apache.org/

Apache License 2.0

6.56k stars 1.17k forks source link

update scheduler not processing metric to counter #5405

Closed bdoyle0182 closed 1 year ago

bdoyle0182 commented 1 year ago

Description

This metric unfortunately does not work as a gauge. A gauge will report until there is a change in the value. I previously made a change so that the value would change back to 0 when a new activation is processed. However this does not account for 1. when the queue is stopped before setting the value back to 0 and 2. a queue is moved to a new host before the value is set back to 0 so the value for the action is still emitting 1 until a restart incorrectly reporting.

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[X] Scheduler
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[X] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[X] I signed an Apache CLA.
[X] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

codecov-commenter commented 1 year ago

Codecov Report

Merging #5405 (ccfac09) into master (d84e4ee) will decrease coverage by 1.05%. The diff coverage is 0.00%.

:exclamation: Current head ccfac09 differs from pull request most recent head 43ba7da. Consider uploading reports for the commit 43ba7da to get more accurate results

@@            Coverage Diff             @@
##           master    #5405      +/-   ##
==========================================
- Coverage   76.69%   75.65%   -1.05%     
==========================================
  Files         240      240              
  Lines       14596    14592       -4     
  Branches      671      666       -5     
==========================================
- Hits        11194    11039     -155     
- Misses       3402     3553     +151

Impacted Files	Coverage Δ
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala	`81.03% <0.00%> (+0.59%)`	:arrow_up:

... and 34 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more