Closed style95 closed 1 year ago
This seems like it's from my two most recent PR's but I'm not sure why it wouldn't have been detected on build or if I had applied the wrong scalafmt?
But I also think it should be caught by CI tests. Our CI checks that. https://github.com/apache/openwhisk/blob/master/tools/github/scan.sh#L41
Merging #5415 (632ed73) into master (72bb2a1) will decrease coverage by
0.09%
. The diff coverage is66.66%
.:exclamation: Current head 632ed73 differs from pull request most recent head cec7c3f. Consider uploading reports for the commit cec7c3f to get more accurate results
@@ Coverage Diff @@
## master #5415 +/- ##
==========================================
- Coverage 76.83% 76.75% -0.09%
==========================================
Files 241 241
Lines 14630 14630
Branches 616 616
==========================================
- Hits 11241 11229 -12
- Misses 3389 3401 +12
Impacted Files | Coverage Δ | |
---|---|---|
...enwhisk/core/entity/InstanceConcurrencyLimit.scala | 75.00% <ø> (ø) |
|
.../openwhisk/core/entity/IntraConcurrencyLimit.scala | 90.32% <ø> (ø) |
|
...che/openwhisk/core/loadBalancer/LeanBalancer.scala | 0.00% <0.00%> (ø) |
|
...pache/openwhisk/core/invoker/InvokerReactive.scala | 71.53% <ø> (ø) |
|
.../org/apache/openwhisk/core/controller/Limits.scala | 91.30% <100.00%> (ø) |
|
...la/org/apache/openwhisk/core/invoker/Invoker.scala | 72.15% <100.00%> (ø) |
... and 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Description
I am not quite sure when this regression is introduced and why our CI could not catch it in the first place, but anyway, codes are wrongly formatted. This change just applies one from scalaFmt.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: