Fix runtime tags in 2.0.0 branch

apache / openwhisk

Apache OpenWhisk is an open source serverless cloud platform

https://openwhisk.apache.org/

Apache License 2.0

6.55k stars 1.17k forks source link

Fix runtime tags in 2.0.0 branch #5473

Closed style95 closed 8 months ago

style95 commented 8 months ago

Description

This is to fix the runtime tag in the 2.0.0 branch. The base branch to merge this change into is the 2.0.0 branch.

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Scheduler
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[x] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

style95 commented 8 months ago

hm.. the CI tests do not run for this branch.

dgrove-oss commented 8 months ago

hm.. the CI tests do not run for this branch.

Yeah. We forgot about the release branch in the main openwhisk repo when we ported to GitHub Actions. All of our workflow files have stanzas like this: https://github.com/apache/openwhisk/blob/5d0ce630da84e28b4c437cbe319a2cc2b96928a3/.github/workflows/4-standalone.yaml#L24

We'll need to do a PR to the main branch to add the release branch to all of the workflow files.

dgrove-oss commented 8 months ago

Going to close and reopen to see if that will trigger CI now that #5474 is merged.

dgrove-oss commented 8 months ago

You might have to rebase 2.0.0 and/or the PR branch on main to cause it to "see" the change to the workflow files.

dgrove-oss commented 8 months ago

I cherry-picked #5474 into the 2.0.0 branch. Tests running now.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.52%. Comparing base (5d0ce63) to head (367749d). Report is 1 commits behind head on 2.0.0.

:exclamation: Current head 367749d differs from pull request most recent head fd6dc66. Consider uploading reports for the commit fd6dc66 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 2.0.0 #5473 +/- ## ========================================== - Coverage 78.21% 4.52% -73.69% ========================================== Files 241 241 Lines 14650 14650 Branches 644 644 ========================================== - Hits 11458 663 -10795 - Misses 3192 13987 +10795 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

style95 commented 8 months ago

@dgrove-oss Thank you! I will take a look at failed tests.

style95 commented 8 months ago

It seems the CI tests require images with the 2.0.0 tag.

TASK [apigateway : (re)start apigateway] ***************************************
Friday 22 March 2024  01:16:18 +0000 (0:00:00.904)       0:00:06.533 ********** 
fatal: [172.17.0.1]: FAILED! => {"changed": false, "msg": "Error pulling image openwhisk/apigateway:2.0.0 - 404 Client Error: Not Found (\"manifest for openwhisk/apigateway:2.0.0 not found: manifest unknown: manifest unknown\")"}

~~I would trigger this job: https://ci-builds.apache.org/job/OpenWhisk/job/OpenWhisk-DockerHub-ReleaseBranch/~~

ok that image is not built by the job. I've just changed the api-gateway tag to 1.0.0.

style95 commented 8 months ago

It's now ready to merge.