ORC-1100: Support `vcpkg`

dongjoon-hyun commented 11 months ago

There exists a request from Apache Arrow community for Apache ORC community to support vcpkg.

https://vcpkg.io/en/index.html

Mailing List

https://lists.apache.org/thread/l3wjm2r6l57pz1q3o7wx57zvgzh7nxgl

Arrow community

https://github.com/apache/arrow/pull/12220#issuecomment-1019343606

dongjoon-hyun commented 9 months ago

This is removed from Milestone 2.0.0.

deshanxiao commented 9 months ago

Hi @dongjoon-hyun I check the vcpkg list and it shows that ORC 1.9.1 has been supported. Could you explain this task in detail? Is this to support ORC2.0?

dongjoon-hyun commented 9 months ago

Thank you for taking a look at this. I copied the JIRA content and pasted into this issue description.

IIUC, the existing one is done by Arrow community instead of ORC community. They asked us to do by ourselves during the Apache ORC release process.

dongjoon-hyun commented 9 months ago

BTW, do you know how to update it with our latest ORC 1.9.2? Can we document it in our website for next release managers?

https://downloads.apache.org/orc/orc-1.9.2/

deshanxiao commented 9 months ago

@dongjoon-hyun We should make a PR to microsoft/vcpkg Here is the last one https://github.com/microsoft/vcpkg/pull/34026

deshanxiao commented 9 months ago

I'd be happy to add this documentation soon.

dongjoon-hyun commented 9 months ago

It's great. Thank you, @deshanxiao !

dongjoon-hyun commented 9 months ago

Let me include this topic back to Milestone 2.0.0.

deshanxiao commented 9 months ago

Add a link to support ORC v1.9.2 https://github.com/microsoft/vcpkg/pull/36098

cc @dongjoon-hyun @wgtmac

deshanxiao commented 9 months ago

We may consider removing the unofficial tag in the future.

orc provides CMake targets:

    find_package(unofficial-orc CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::orc::orc)

wgtmac commented 9 months ago

Thanks @deshanxiao and @dongjoon-hyun!

orc provides CMake targets:

    find_package(unofficial-orc CONFIG REQUIRED)
    target_link_libraries(main PRIVATE unofficial::orc::orc)

BTW, where is this?

dongjoon-hyun commented 9 months ago

vcpkg has that in the orc usage, @wgtmac .

https://github.com/microsoft/vcpkg/blob/master/ports/orc/usage

orc provides CMake targets:

find_package(unofficial-orc CONFIG REQUIRED)
target_link_libraries(main PRIVATE unofficial::orc::orc)

And, vcpkg code itself publishes like this.

https://github.com/microsoft/vcpkg/blob/c9919121dde6f61c0436adda94624636e041226b/ports/orc/portfile.cmake#L55-L59
```
vcpkg_cmake_config_fixup(PACKAGE_NAME unofficial-orc)
vcpkg_copy_pdbs()
```

file(READ "${CURRENT_PACKAGES_DIR}/share/unofficial-orc/unofficial-orc-config.cmake" cmake_config) file(WRITE "${CURRENT_PACKAGES_DIR}/share/unofficial-orc/unofficial-orc-config.cmake"

dongjoon-hyun commented 9 months ago

Also, cc @williamhyun , too.

dongjoon-hyun commented 9 months ago

BTW, FYI, I filed your account request form, @deshanxiao . Since the desired ID was not provided on the ICLA, the creation is slipped from the secretary to the ORC PMC Chair. And, it seems that PMC Chair seems to be busy after orc-format release, so I filed your form because I can do that as the ASF member.

https://infra.apache.org/managing-committers.html

Encourage your new committer to include both the PMC and the desired account id on the submitted ICLA
so the secretary or assistant filing the ICLA can request the account.
If the new account information is not provided on the ICLA,
the PMC chair is responsible for getting the new committer's desired account ID and requesting the new account.
Use the [New Account Request form](https://whimsy.apache.org/officers/acreq) on Whimsy.
Should the PMC chair be unavailable for any reason, any ASF member can use the same form in their stead.

deshanxiao commented 9 months ago

Great! Thank you @dongjoon-hyun

dongjoon-hyun commented 9 months ago

Hi, @deshanxiao .

For this issue (ORC-1100), could you try to make a webpage PR to add a new section about vcpkg at this file?