search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
689 stars 483 forks source link

ORC-1587: Fix usage command of SparkBenchmark document #1749

Closed cxzl25 closed 9 months ago

cxzl25 commented 9 months ago

What changes were proposed in this pull request?

java -jar spark/target/orc-benchmarks-spark-${ORC_VERSION}.jar spark data

Why are the changes needed?

java -jar spark/target/orc-benchmarks-spark-*.jar spark data
Error: Invalid or corrupt jarfile spark/target/orc-benchmarks-spark-2.1.0-SNAPSHOT-nohive.jar

How was this patch tested?

local test

Was this patch authored or co-authored using generative AI tooling?

No

paliwalashish commented 9 months ago

Can we be more descriptive in description as to what we are trying to do? This shall help later. I am able to reproduce this, however we also need to find out why we are getting the corrupt jar error.

cxzl25 commented 9 months ago

however we also need to find out why we are getting the corrupt jar error.

https://github.com/apache/orc/blob/ffb0c87c94c8e1b5e0a7d722586585a1e1c23cfa/java/pom.xml#L536-L549