Closed cxzl25 closed 6 months ago
Good catch, Thanks!
In fact, I made a wrong decision to directly put the array into directOut
since I misjudged the length of the array.
I prefer to change directOut.put(out.array());
to directOut.put(out);
What do you think? @cxzl25
Thanks @dongjoon-hyun , I have updated the PR title and description.
Merged to main/2.1. Thank you, @cxzl25 @paliwalashish @dongjoon-hyun !
Great! Thank you all!
Hi, @deshanxiao . branch-2.0
didn't have this patch. Did you use this merge script?
Please note that main
is Apache ORC 2.1.0.
Thanks @dongjoon-hyun , I have changed the comment and jira.
Oh, we had better backport this to branch-2.0, didn't we?
Thanks @dongjoon-hyun Cherry-pick the fix to branch-2.0
What changes were proposed in this pull request?
Set ByteBuffer limit in
TestBrotli
testWhy are the changes needed?
TestBrotli#testDirectDecompress
attempts to put the compressed result in direct ByteBuffer. When callingdecompress
, we will find that the input buffer length is still10000
not217
since we put the array withoutlimit
on the length.This PR is aimed to use
directOut.put(out)
instead ofdirectOut.put(out.array())
How was this patch tested?
GA
Was this patch authored or co-authored using generative AI tooling?
No