search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
675 stars 480 forks source link

ORC-1618: Disable building tests for snappy #1792

Closed douardda closed 6 months ago

douardda commented 7 months ago

Disabling the building of tests is a workaround for issue #1791 and is probably not an issue since snappy tests are not executed as part of the build process of orc c++ libs.

Note that snappy 1.1.9 and 1.1.10 cannot be used as is because source assets on snappy's gh page are not buildable out of the box, so stick to 1.1.8 for now.

What changes were proposed in this pull request?

Disable building snappy tests as a workaround for issue #1791.

Why are the changes needed?

compilation broken in some situations otherwise (see issue)

How was this patch tested?

compile & unit tests

Was this patch authored or co-authored using generative AI tooling?

no

douardda commented 6 months ago

I've updated the PR to only keep the 'disable build tests' part.

dongjoon-hyun commented 6 months ago

I've updated the PR to only keep the 'disable build tests' part.

Thank you for update, @douardda . Please update the PR title and description accordingly.

dongjoon-hyun commented 6 months ago

Merged to main/2.0/1.9.