search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
675 stars 480 forks source link

ORC-1622: [C++] Support conan packaging #1805

Closed wgtmac closed 6 months ago

wgtmac commented 6 months ago

What changes were proposed in this pull request?

Add conan recipe for the C++ library. The latest release of supported versions are added by default.

Why are the changes needed?

Conan is a popular C++ package manager: https://docs.conan.io/2/index.html. It would be good to support conan recipe on our end.

How was this patch tested?

Test it locally using conan command.

Was this patch authored or co-authored using generative AI tooling?

No

wgtmac commented 6 months ago

@dongjoon-hyun @deshanxiao Could you please take a look? Thanks!

wgtmac commented 6 months ago

@dongjoon-hyun Thanks for the feedback! Please see my comment below.

Are you going to publish all live releases (1.9/1.8/1.7) in this way?

I have only added the latest version of each live release in case people want to stay on an older version.

I'm curious if this is a standard way to maintain Conan stuff (version list, receipt, package test code). It looks quite different from Homebrew or vcpkg ways.

The standard way to maintain conan recipe is to put them in the conan-center-index:

Apache Arrow has also put a copy of that from conan-center-index with a slight modification: https://github.com/apache/arrow/tree/main/ci/conan/all. This is used in the release process and also facilitate users to customize their own conan recipe or use an unofficial version (e.g. current main branch).

I will upstream these to the conan-center-index and keep them in sync.

deshanxiao commented 6 months ago

Thank you @wgtmac. +1 LGTM. Do you have plan to add document make-release.md in this PR?

wgtmac commented 6 months ago

Thank you @wgtmac. +1 LGTM. Do you have plan to add document make-release.md in this PR?

Thanks for the suggestion! I will update it once this gets merged in the conan-center-index.

wgtmac commented 6 months ago

I just merged this. Thanks @dongjoon-hyun and @deshanxiao. I will upstream this to the conan community.

dongjoon-hyun commented 6 months ago

Please cherry-pick this to branch-2.0 too, @wgtmac .