search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
671 stars 477 forks source link

ORC-1638: Avoid `System.exit(0)` in `count` command #1825

Closed cxzl25 closed 4 months ago

cxzl25 commented 4 months ago

What changes were proposed in this pull request?

This PR aims to avoid System.exit(0) in count command.

Why are the changes needed?

https://github.com/apache/orc/pull/1817#discussion_r1503572991

System.exit(0) is not conducive to testing, especially in Java17 and above. Without System.exit(0), the program can exit normally.

How was this patch tested?

local test

Was this patch authored or co-authored using generative AI tooling?

No

dongjoon-hyun commented 4 months ago

Thank you!