Closed georgthegreat closed 4 months ago
Thanks for the fix! Do you have access to the JIRA to create an issue for this?
Thanks for the fix! Do you have access to the JIRA to create an issue for this?
I have flagged ORC-1657 with the description.
Thanks! +1
It seems that I have trouble in merging this:
➜ orc git:(main) ✗ ./dev/merge_orc_pr.py
git rev-parse --abbrev-ref HEAD
Which pull request would you like to merge? (e.g. 34): 1850
Restoring head pointer to main
git checkout main
Already on 'main'
git branch
Traceback (most recent call last):
File "/Users/gangwu/Projects/orc/./dev/merge_orc_pr.py", line 555, in <module>
main()
File "/Users/gangwu/Projects/orc/./dev/merge_orc_pr.py", line 465, in main
modified_body = re.sub(re.compile(r"<!--[^>]*-->\n?", re.DOTALL), "", pr["body"]).lstrip()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/homebrew/Cellar/python@3.11/3.11.7_1/Frameworks/Python.framework/Versions/3.11/lib/python3.11/re/__init__.py", line 185, in sub
return _compile(pattern, flags).sub(repl, string, count)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: expected string or bytes-like object, got 'NoneType'
I have added PR description, it should merge now.
clang-cl defines both
_clang_
and_MSC_VER
yet it uses MSVC-specific way to handle#pragma warning ignore