Closed ffacs closed 3 months ago
This patch I`ve done the following things:
cd builf && python3 ../run_clang_tidy.py -p . -fix
git ls-files --exclude-standard | grep ".*\(cc\|hh\)$" | xargs clang-format -i -style=file --dump-config
Currently the patch can be built on my macOS(arm Apple clang version 15.0.0) and ubuntu(x64 clang-18) and passes UTs with mkdir build -p && cd build && cmake .. -DBUILD_JAVA=OFF -DCMAKE_BUILD_TYPE=DEBUG -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang -DCMAKE_EXPORT_COMPILE_COMMANDS=1 && make -j20 && make test
.
@dongjoon-hyun Hi, do you have any suggestions about this patch?
@dongjoon-hyun Hi, do you have any suggestions about this patch?
Although I've been monitoring this PR and discussion, there is no other objection for the AS-IS direction including backward compatibility consideration.
Thank you!
What changes were proposed in this pull request?
Why are the changes needed?
To close https://github.com/apache/orc/issues/1845
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO