search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
670 stars 477 forks source link

ORC-1663: [C++] Enable TestTimezone.testMissingTZDB on Windows #1856

Closed wgtmac closed 4 months ago

wgtmac commented 4 months ago

What changes were proposed in this pull request?

Enable TestTimezone.testMissingTZDB unit test to run on Windows.

Why are the changes needed?

When /usr/share/zoneinfo is unavailable and TZDIR env is unset, creating C++ ORC reader will crash on Windows. We need to better deal with this case. See context from the Apache Arrow community: https://github.com/apache/arrow/issues/36026 and https://github.com/apache/arrow/issues/40633

How was this patch tested?

Make sure the test passes on Windows.

Was this patch authored or co-authored using generative AI tooling?

No.

dongjoon-hyun commented 4 months ago

Merged to main/2.0.

wgtmac commented 4 months ago

Thanks @dongjoon-hyun !