search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
671 stars 477 forks source link

ORC-1662: [C++] Upgrade protobuf to 3.21.12 #1857

Open ffacs opened 4 months ago

ffacs commented 4 months ago

What changes were proposed in this pull request?

Upgrade protobuf to 3.21.12

Why are the changes needed?

To fix compilation failure on vs2022

How was this patch tested?

UT passed

Was this patch authored or co-authored using generative AI tooling?

NO

wgtmac commented 4 months ago

Thanks for the PR! Unfortunately the new protobuf version is not compatible to compile libhdfspp. Let me investigate this.

wgtmac commented 4 months ago

Update: I tried to upgrade libhdfspp. But unfortunately, I ran this command https://github.com/apache/orc/blob/main/c%2B%2B/libs/libhdfspp/pull_hdfs.sh#L25 without check. It wiped out my current directory (which is the root user profile).

dongjoon-hyun commented 4 months ago

Oh, too bad for the accident.