search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
665 stars 477 forks source link

ORC-1686: [C++] Avoid using std::filesystem #1886

Closed wgtmac closed 2 months ago

wgtmac commented 2 months ago

What changes were proposed in this pull request?

Remove std::filesystem and use OS API instead.

Why are the changes needed?

Apache Arrow C++ library is required to support old compilers like clang8. Since Apache ORC C++ library has used std::filesystem to check TZDB availability since 2.0.0, Apache Arrow requires to add more linking options for std::filesystem. See https://github.com/apache/arrow/pull/41023 for detail.

How was this patch tested?

Passing CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

dongjoon-hyun commented 2 months ago

I added 2.0.1 as the milestone. Thank you for doing this follow-up, @wgtmac .

dongjoon-hyun commented 2 months ago

Merged to main/2.0.

wgtmac commented 2 months ago

Thanks @dongjoon-hyun! Yes, it should be ported to 2.0.1 as well.