search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
682 stars 481 forks source link

ORC-1688: [C++] Do not access TZDB if there is no timestamp type #1893

Closed ffacs closed 5 months ago

ffacs commented 5 months ago

What changes were proposed in this pull request?

  1. Don't write writer's Time Zone name when there are no timestamp types.
  2. Do not access TZDB if there is no timestamp type.

Why are the changes needed?

This patch could accelerate reading by reducing unnecessary IO.

How was this patch tested?

All UT passed.

Was this patch authored or co-authored using generative AI tooling?

NO

ffacs commented 5 months ago

This implementation should be better than prior one.

wgtmac commented 5 months ago

Nice fix! Will take a deeper look at it tomorrow.