apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
665 stars 477 forks source link

ORC-1690: [C++] Refactor CMake to use imported third-party libraries #1894

Closed wgtmac closed 2 months ago

wgtmac commented 2 months ago

What changes were proposed in this pull request?

Why are the changes needed?

To generate cmake config file, we need to use IMPORT for dependencies.

How was this patch tested?

Was this patch authored or co-authored using generative AI tooling?

No.

coderex2522 commented 2 months ago

LGTM. Thank you @wgtmac

wgtmac commented 2 months ago

Thanks @ffacs and @coderex2522 for the review!

dongjoon-hyun commented 2 months ago

Hi, All. Thank you for all your efforts.

Please use the provided merge script next time.

Since this is merge at Web Browser, there are three mistakes at least.

  1. The JIRA issue is not still resolved correctly, ORC-1690.

Screenshot 2024-04-17 at 08 58 05

  1. The commit lost the PR description

  2. The commit message didn't have Sign-off message. Screenshot 2024-04-17 at 09 00 13

dongjoon-hyun commented 2 months ago

cc @coderex2522

wgtmac commented 2 months ago

@dongjoon-hyun Do we need to revert the commit and recreate the same PR?

dongjoon-hyun commented 2 months ago

Oh, no~ :)

dongjoon-hyun commented 2 months ago

The merge script exists to help us instead of blocking us. That's what I want to say.