Closed wgtmac closed 2 months ago
LGTM. Thank you @wgtmac
Thanks @ffacs and @coderex2522 for the review!
Hi, All. Thank you for all your efforts.
Please use the provided merge script next time.
Since this is merge at Web Browser, there are three mistakes at least.
The commit lost the PR description
The commit message didn't have Sign-off
message.
cc @coderex2522
@dongjoon-hyun Do we need to revert the commit and recreate the same PR?
Oh, no~ :)
The merge script exists to help us instead of blocking us. That's what I want to say.
What changes were proposed in this pull request?
Why are the changes needed?
To generate cmake config file, we need to use IMPORT for dependencies.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No.