apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
665 stars 477 forks source link

ORC-1698: Upgrade `commons-cli` to 1.7.0 #1907

Closed cxzl25 closed 2 months ago

cxzl25 commented 2 months ago

What changes were proposed in this pull request?

This PR aims to upgrade commons-cli to 1.7.0.

Why are the changes needed?

Release 1.7.0 – 2024-04-13

https://commons.apache.org/proper/commons-cli/changes-report.html#a1.7.0

The default value of getOptionValue is null. After upgrading to 1.7.0, a new method was introduced, causing compilation to fail.

this.bloomFilterColumns = opts.getOptionValue('b', null);
Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project orc-tools: Compilation failure
Error:  /root/orc/java/tools/src/java/org/apache/orc/tools/convert/ConvertTool.java:[202,35] reference to getOptionValue is ambiguous
Error:    both method getOptionValue(char,java.lang.String) in org.apache.commons.cli.CommandLine and method getOptionValue(char,java.util.function.Supplier<java.lang.String>) in org.apache.commons.cli.CommandLine match

How was this patch tested?

GA

Was this patch authored or co-authored using generative AI tooling?

No

Closes #1906

dongjoon-hyun commented 2 months ago

To @cxzl25 , you can add the following at the end of your PR description. Then, GitHub will automatically close #1906 when this (#1907) is merged.

Closes #1906
cxzl25 commented 2 months ago

you can add the following at the end of your PR description

Thank you for your reminder. I have updated it.

dongjoon-hyun commented 2 months ago

Thank you. Merged to main/2.0.