search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
665 stars 477 forks source link

ORC-1706: [C++] Fix build break w/ BUILD_CPP_ENABLE_METRICS=ON #1915

Closed ffacs closed 2 months ago

ffacs commented 2 months ago

What changes were proposed in this pull request?

  1. Fix build break w/ BUILD_CPP_ENABLE_METRICS=ON
  2. Add -DBUILD_CPP_ENABLE_METRICS=ON on format check actions.
  3. Fix a typo on README file name.

Why are the changes needed?

C++ build breaks when the option BUILD_CPP_ENABLE_METRICS is switched on.

How was this patch tested?

UT passed.

Was this patch authored or co-authored using generative AI tooling?

NO

dongjoon-hyun commented 2 months ago

Feel free to merge, @wgtmac ~ :)

ffacs commented 2 months ago

Got it. Are these all leftovers due to the recent variable renaming change?

Yes

wgtmac commented 2 months ago

I just merged it. Thanks @ffacs and @dongjoon-hyun!