ORC-1733: [C++][CMake] Fix CMAKE_MODULE_PATH not to use PROJECT_SOURCE_DIR - Githubissues

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads

https://orc.apache.org/

Apache License 2.0

681 stars 482 forks source link

ORC-1733: [C++][CMake] Fix CMAKE_MODULE_PATH not to use PROJECT_SOURCE_DIR #1959

Closed wgtmac closed 3 months ago

wgtmac commented 3 months ago

What changes were proposed in this pull request?

Change PROJECT_SOURCE_DIR to CMAKE_CURRENT_SOURCE_DIR for CMAKE_MODULE_PATH.

Why are the changes needed?

Line below is not portable when ORC is used by downstream projects:

set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${PROJECT_SOURCE_DIR}/cmake_modules")

How was this patch tested?

Make sure all CIs pass.

Was this patch authored or co-authored using generative AI tooling?

No.