search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
665 stars 477 forks source link

Respect Decimal isRepeating flag #1960

Open cxzl25 opened 1 week ago

cxzl25 commented 1 week ago

What changes were proposed in this pull request?

Decimal type, when isRepeating itself is false, do not try to change it.

Why are the changes needed?

https://github.com/apache/hive/pull/5218#discussion_r1647367003

How was this patch tested?

Add UT

Was this patch authored or co-authored using generative AI tooling?

No

difin commented 1 week ago

Hi @cxzl25, I did a test on my local env: backported this patch into Orc branch 1.9, built Hive with it then run the Hive query test that had been failing before and it passed. Can you please create a new Orc release from branch 1.9 so that we could use it in Hive? This is because we can't use Orc 2.0 or later because it requires Java 17+ and Hive still support Java 8.