search

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads
https://orc.apache.org/
Apache License 2.0
665 stars 477 forks source link

ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS #1963

Open luffy-zh opened 1 week ago

luffy-zh commented 1 week ago

What changes were proposed in this pull request?

Detect Protobuf installed by Homebrew on macOS.

Why are the changes needed?

Deal with the issue discussed here

How was this patch tested?

Test it locally.

Was this patch authored or co-authored using generative AI tooling?

NO

wgtmac commented 1 week ago

@kou Could you help review this? Thanks!

wgtmac commented 3 days ago

The new github action doesn't run. I found the error message below:

Invalid workflow file: .github/workflows/build_and_test.yml#L224
The workflow is not valid. .github/workflows/build_and_test.yml (Line: 224, Col: 7): 'run' is already defined .github/workflows/build_and_test.yml (Line: 225, Col: 7): 'run' is already defined

https://github.com/apache/orc/actions/runs/9746489872