ORC-1738: [C++] Fix wrong Int128 maximum value

apache / orc

Apache ORC - the smallest, fastest columnar storage for Hadoop workloads

https://orc.apache.org/

Apache License 2.0

671 stars 477 forks source link

ORC-1738: [C++] Fix wrong Int128 maximum value #1970

Closed letian-jiang closed 1 week ago

letian-jiang commented 2 weeks ago

What changes were proposed in this pull request?

Why are the changes needed?

The low part of Int128::maximumValue is wrong. In hex format, it should be 0xffffffffffffffff rather than 0xfffffffffffffff, in which one f is dropped by mistake.

How was this patch tested?

I have added the relevant unit tests.

Was this patch authored or co-authored using generative AI tooling?

No.

ffacs commented 1 week ago

It's an issue from day one; perhaps we should consider cherry-picking it into branch-1.0.

dongjoon-hyun commented 1 week ago

Welcome to the Apache ORC community, @letian-jiang . I added you to the Apache ORC contributor group and assigned ORC-1738 to you. Thank you again!

dongjoon-hyun commented 1 week ago

cc @williamhyun too because he is a release manager of ORC 1.9.4.