[Bug] Snapshot expire may have unexpected behavior when snapshot.num-retained.min = 0 - Githubissues

apache / paimon

Apache Paimon is a lake format that enables building a Realtime Lakehouse Architecture with Flink and Spark for both streaming and batch operations.

https://paimon.apache.org/

Apache License 2.0

2.39k stars 942 forks source link

[Bug] Snapshot expire may have unexpected behavior when snapshot.num-retained.min = 0 #1167

Closed qidian99 closed 1 year ago

qidian99 commented 1 year ago

Search before asking

[X] I searched in the issues and found nothing similar.

Paimon version

0.5-SNAPSHOT

Compute Engine

Flink

Minimal reproduce step

Setting snapshot.num-retained.min=0 in table property will cause all snapshots being expired after the maximum retain time of completed snapshots.

What doesn't meet your expectations?

snapshot.num-retained.min should be greater than or equal to 1, so that we always has at least 1 snapshot.

Anything else?

No response

Are you willing to submit a PR?

[X] I'm willing to submit a PR!

zhuangchong commented 1 year ago

The related PR has been merged into the master repository, and I will close this issue.