[core] Check the validity of scan staring snapshotId - Githubissues

apache / paimon

Apache Paimon is a lake format that enables building a Realtime Lakehouse Architecture with Flink and Spark for both streaming and batch operations.

https://paimon.apache.org/

Apache License 2.0

2.13k stars 842 forks source link

[core] Check the validity of scan staring snapshotId #3554

Closed LinMingQiang closed 2 weeks ago

LinMingQiang commented 2 weeks ago

…correct exception.

Purpose

Linked issue: close #xxx

Tests

API and Format

Documentation

leaves12138 commented 2 weeks ago

Starting snapshot in IncrementableScan seems could be less than earliest snapshot id.

leaves12138 commented 2 weeks ago

This pull request should not effect scan between timestamp...

LinMingQiang commented 2 weeks ago

Based on my understanding ,because of the left open right closed rule of IncrementalStartingScanner that is different from StaticFromStartingScanner, we should allow starting snapshotId to be equal to the earliestSnapshotId - 1like 0.

LinMingQiang commented 2 weeks ago

@JingsongLi Help to review this PR, thanks.