PARQUET-2492: Add extension points for all thrift messages - Githubissues

apache / parquet-format

Apache Parquet Format

https://parquet.apache.org/

Apache License 2.0

1.69k stars 422 forks source link

PARQUET-2492: Add extension points for all thrift messages #254

Open alkis opened 1 month ago

alkis commented 1 month ago

Specify a backwards/forward compatible way to extend any Thrift struct in Parquet.

ref Parquet Metadata evolution

Jira

[x] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-2492
- In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Commits

[x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters (not including Jira issue reference)
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

Documentation

[ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does

alkis commented 3 weeks ago

I marked this ready for review. I have tested offline that this method works as expected and has virtually no impact in parse speed of the original FileMetaData thrift message.

How can we move this forward?