apache / parquet-format

Apache Parquet Format
https://parquet.apache.org/
Apache License 2.0
1.69k stars 422 forks source link

Use `true` instead of `1` as default value for `is_compressed bool` field #418

Closed asfimport closed 1 year ago

asfimport commented 1 year ago

I noticed that the default value for the optional boolean is_compressed field of the DataPageHeaderV2 struct has a default value of 1. According to the Thrift docs a boolean value is either true or false

This currently works because the Apache Thrift compiler internally handles bools as ints:

Reporter: Matthijs Brobbel / @mbrobbel Assignee: Matthijs Brobbel / @mbrobbel

Externally tracked issue: https://github.com/apache/parquet-format/pull/210

Note: This issue was originally created as PARQUET-2299. Please see the migration documentation for further details.