PARQUET-2465: Fall back to HadoopConfig

[Fokko]

We see that this causes the 1.14 to be incompatible with the previous releases.

• Previously it would just create the Hadoop Configuration: https://github.com/apache/parquet-mr/pull/1141/files#diff-1ad34fccaed5421e95285fbcceaf63d9d55b8460b5fb301b65468f8a15603b5fL356
• Now the ParquetConfig will be created and the getWriteSupport(conf) is called: https://github.com/apache/parquet-mr/pull/1141/files#diff-1ad34fccaed5421e95285fbcceaf63d9d55b8460b5fb301b65468f8a15603b5fR784
• But since this method is freshly introduced:

  protected WriteSupport<T> getWriteSupport(ParquetConfiguration conf) {
    throw new UnsupportedOperationException(
        "Override ParquetWriter$Builder#getWriteSupport(ParquetConfiguration)");
  }

  It is not implemented and causes an UnsupportedOperationException if you don't supply a config.

• I think this breaks backward compatibility.

Jira

• [ ] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
  • https://issues.apache.org/jira/browse/PARQUET-2465
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

• [ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Style

• [ ] My contribution adheres to the code style guidelines and Spotless passes.
  • To apply the necessary changes, run mvn spotless:apply -Pvector-plugins

Documentation

• [ ] In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain Javadoc that explain what it does

[Fokko]

Good to go. @wgtmac @shangxinli @amousavigourabi @vinooganesh LMKWYT

[vinooganesh]

👍 this looks good to me, but do we want to actually mark the hadoop methods as deprecated if we are going to assume that parquet-mr 1.x will always rely on hadoop? Or is there actually a plan to drop the hadoop dependency on future 1.x releases?

[Fokko]

👍 this looks good to me, but do we want to actually mark the hadoop methods as deprecated if we are going to assume that parquet-mr 1.x will always rely on hadoop? Or is there actually a plan to drop the hadoop dependency on future 1.x releases?

You can still use the Hadoop config, but you'll need to wrap it into a HadoopParquetConfiguration: https://github.com/apache/parquet-mr/blob/68609198c4fecaa0e8fb1bcaa2c8a353030de962/parquet-hadoop/src/main/java/org/apache/parquet/conf/HadoopParquetConfiguration.java#L42-L44

[amousavigourabi]

👍 this looks good to me, but do we want to actually mark the hadoop methods as deprecated if we are going to assume that parquet-mr 1.x will always rely on hadoop? Or is there actually a plan to drop the hadoop dependency on future 1.x releases?

I'd like to note that we have other stuff that is deprecated because they will be dropped in 2.0 without any plans to remove them in 1.x releases as well (see: org.apache.parquet.avro.AvroParquetReader#builder(Path) for an example of this), so this is consistent with the usage in the rest of the project.

[vinooganesh]

Sounds great, thank @Fokko and @amousavigourabi!